Refactor the 'resize' event handler in viewer.js (issue 6158) #6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*This is the next step towards fixing 6158.* This patch removes the dependency on the state of the scale `<select>` dropdown from the `resize` event handler, and instead uses the (in `PDFViewer`) stored `currentScaleValue`. I believe that the way this code is currently written is purely for historical reasons, since originally *only* the numerical scale was stored internally (hence there was no other way to access the scale value). However, since we now store the scale value, we should use it instead of quering the DOM. This helps ensure that the internally stored scale value is always accurately displayed in the UI (which should be good since, after the creation of `PDFViewer`, the `<select>` DOM element is now updated by an event handler).
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/da87e845c8a63ca/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/da87e845c8a63ca/output.txt Total script time: 0.64 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Jul 10, 2015
Refactor the 'resize' event handler in viewer.js (issue 6158)
|
Looks much better than before, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step towards fixing #6158.
This patch removes the dependency on the state of the scale
<select>dropdown from theresizeevent handler, and instead uses the (inPDFViewer) storedcurrentScaleValue.I believe that the way this code is currently written is purely for historical reasons, since originally only the numerical scale was stored internally (hence there was no other way to access the scale value).
However, since we now store the scale value, we should use it instead of quering the DOM. This helps ensure that the internally stored scale value is always accurately displayed in the UI (which should be good since, after the creation of
PDFViewer, the<select>DOM element is now updated by an event handler).@timvandermeij Since you've been kind enough to review the previous patches in this series, could you please review this one as well?